Small Travis CI improvements #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoe
changed the title
cardoe
force-pushed
the
small-travis-improvements
branch
2 times, most recently
from
c6a5663
to
087e9c4
Compare
|
Overall 👍 aside from the comments above. |
|
Oh this PR isn't ready to go yet. I just had to configure Travis CI for the project cause it hadn't been migrated yet. So I opened the PR as a WIP so that I could test that I did the right thing for Travis to be happy. |
|
Ah, I missed that part (reviewing on mobile). Good thing I didn't give it the formal +1! |
ghost
approved these changes
Jan 17, 2019
drewbrew
reviewed
Jan 18, 2019
Signed-off-by: Doug Goldstein <doug.goldstein@rackspace.com>
Added a lot more errors/warnings to the list so that things would still pass. Follow on commits will back off these one by one so make the review process easier.
The setup.cfg is a better place to store the list of settings for flake8.
This package does not currently have Python 3 support so it shouldn't advertise itself as universal.
cardoe
force-pushed
the
small-travis-improvements
branch
from
51b550e
to
b2694a4
Compare
|
Should be ready for re-review. |
cardoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just getting started on cleaning up the build process with Travis CI. Switches to flake8, builds the sdist and wheel as part of Travis. Enables Travis caching. Fixes links in the README.