Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure output is displayed by tee #47

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Ensure output is displayed by tee #47

merged 1 commit into from
Sep 13, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 12, 2021

Fixes error observed with molecule where pipe argument got -1 value, causing tee functionality to not work.

Adds functional testing for subprocess-tee when used from inside molecule.

Fixes: #46

@ssbarnea ssbarnea added the skip-changelog Can be missed from the changelog. label Sep 12, 2021
@ssbarnea ssbarnea force-pushed the fix/chore branch 3 times, most recently from 6997f44 to d198099 Compare September 12, 2021 13:56
@ssbarnea ssbarnea changed the title Add integration testing Ensure output is displayed by tee Sep 12, 2021
@ssbarnea ssbarnea added bug Something isn't working and removed skip-changelog Can be missed from the changelog. labels Sep 12, 2021
@ssbarnea
Copy link
Member Author

It seems that due to jazzband/pip-tools#333 i will need to remove locking of test dependencies.

ssbarnea added a commit that referenced this pull request Sep 13, 2021
@ssbarnea ssbarnea mentioned this pull request Sep 13, 2021
ssbarnea added a commit that referenced this pull request Sep 13, 2021
Tests subprocess-tee when used from inside
molecule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.3.3 critical regression, no output displayed
1 participant