-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put keynote slides #946
Put keynote slides #946
Conversation
…o dev_issue944_keynote_slides
Codecov Report
@@ Coverage Diff @@
## master #946 +/- ##
=======================================
Coverage 75.05% 75.05%
=======================================
Files 80 80
Lines 3083 3083
=======================================
Hits 2314 2314
Misses 769 769 Continue to review full report at Codecov.
|
Wait wait... @Maliaotw 你只是把 json 加了這個欄位但是前端 template 好像不會秀阿 orz |
修正了, 請再幫我看看 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
另外,就是你的 IDE 好像都會把整個縮排做處理,其實這樣就會很難看得出你到底實際上改的是哪些地方 orz
<article data-target="tabbing.pane"> | ||
<a href="{{ data.slides }}">{{ data.slides }}</a> | ||
</article> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你這樣的話,第一是那一整個 tab 會很空,第二個是沒有投影片的人這邊就會點下去是空白的...
我在想,你有沒有辦法把他簡單的做,加在 "演講" 的那個 tab 的內容裡,但是變成很像 social links 那樣,如果有投影片,就放在最下面,例如
{% if data.slides %}
<div class="slides">
Slides: <a href="{{ data.slides }}" target="_blank" rel="noopener">{{ data.slides}}</a>
</div>
{% endif %}
@Maliaotw is this merge request ready to review? If no, you may convert this pr to "draft" (this is a github feature). If yes, please signal us. |
@tai271828 Yes, this PR is done and is currently under review by me. However, since this PR (& also #782) is a part of the 2020 website, I personally wish Tom to be the final reviewer. It's my fault to make it being stale for so long since Tom & I haven't kicked-off the handover tasks until tomorrow (we'll have a meeting in person and go through the checklist for closing the 2020 website). So, please give us more time, and we'll close this PR soon 😅. |
@mattwang44 no problem! I asked to make sure this PR is in people's radar, so we won't waste @Maliaotw 's contribution : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㄜ! 這跟我預期的不太一樣,但這樣子也是可以的啦 orz.
Types of changes
Description
put keynote slides url to file