Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(navigator): rename sigh in to proposal system #373

Merged
merged 1 commit into from
Jan 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions components/core/header/Header.vue
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ export default {
NavBarHamburger,
ScrollableNavBar,
},
computed: {
myPyConUrl() {
return `https://tw.pycon.org/prs/${this.$i18n.locale}/dashboard/`
},
},
}
</script>

Expand Down
4 changes: 2 additions & 2 deletions components/core/header/nav-bar/NavBar.i18n.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default genI18nMessages({
tickets: 'Ticket Info',
financialAid: 'Financial Aid',
venue: 'Venue',
signIn: 'Sign In',
proposalSystemUrl: 'Proposal System',
codeOfConduct: 'Code of Conduct',
},
'zh-hant': {
Expand Down Expand Up @@ -60,7 +60,7 @@ export default genI18nMessages({
tickets: '購票資訊',
financialAid: '財務補助',
venue: '會場',
signIn: '登入',
proposalSystemUrl: '投稿系統',
codeOfConduct: '行為準則',
},
})
8 changes: 4 additions & 4 deletions components/core/header/nav-bar/NavBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@
{{ $t('venue') }}
</locale-link>
<ext-link
:href="signInUrl"
:class="getPageClassesByPath('signIn', true)"
:href="proposalSystemUrl"
:class="getPageClassesByPath('proposalSystemUrl', true)"
>
{{ $t('signIn') }}
{{ $t('proposalSystemUrl') }}
</ext-link>
</nav>
</template>
Expand Down Expand Up @@ -114,7 +114,7 @@ export default {
this.$store.state.configs.registrationHideItems,
)
},
signInUrl() {
proposalSystemUrl() {
return `https://tw.pycon.org/prs/${this.$i18n.locale}/dashboard/`
},
showSponsorPage() {
Expand Down
6 changes: 3 additions & 3 deletions components/core/header/nav-bar/NavBarHamburger.vue
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@
></nav-bar-item-accordion>
<ext-link
class="core-navBarHamburgerSlideInMenu__item"
:href="signInUrl"
>{{ $t('signIn') }}</ext-link
:href="proposalSystemUrl"
>{{ $t('proposalSystemUrl') }}</ext-link
>
</div>
</div>
Expand Down Expand Up @@ -136,7 +136,7 @@ export default {
this.$store.state.configs.registrationHideItems,
)
},
signInUrl() {
proposalSystemUrl() {
return `https://tw.pycon.org/prs/${this.$i18n.locale}/dashboard/`
},
showSponsorPage() {
Expand Down
8 changes: 4 additions & 4 deletions i18n/speaking/cfp.i18n.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default genI18nMessages({
howToSubmit: {
title: 'How to Submit Your Proposal',
description: [
'You need to {signUp} for a new account on our system. With an activated account, you can fill up the speaker profile and create new proposals through the {myPyCon} page.',
'You need to {signUp} for a new account on our system. With an activated account, you can fill up the speaker profile and create new proposals through the {proposalSystem} page.',
'We encourage you to submit the proposal as early as possible. You are welcomed to submit multiple proposals.',
],
steps: [],
Expand Down Expand Up @@ -115,7 +115,7 @@ export default genI18nMessages({
terms: {
aoe: 'AoE',
signUp: 'sign up',
myPyCon: 'My PyCon',
proposalSystem: 'Proposal System',
pyVideo: 'pyvideo.org',
recording: 'recording release',
everyoneContributesPolicy: 'Everyone Contributes Policy',
Expand Down Expand Up @@ -148,7 +148,7 @@ export default genI18nMessages({
howToSubmit: {
title: '提交稿件',
description: [
'您需要先在系統上 {signUp} 一個新的帳號。在啟用您的帳號之後,就可以填寫講者資訊,並從 {myPyCon} 頁面中建立新的投搞。我們強烈建議您儘早送出您的投稿。',
'您需要先在系統上 {signUp} 一個新的帳號。在啟用您的帳號之後,就可以填寫講者資訊,並從 {proposalSystem} 頁面中建立新的投搞。我們強烈建議您儘早送出您的投稿。',
],
steps: [],
},
Expand Down Expand Up @@ -242,7 +242,7 @@ export default genI18nMessages({
terms: {
aoe: 'AoE',
signUp: '註冊',
myPyCon: 'My PyCon',
proposalSystem: '投稿系統',
pyVideo: 'pyvideo.org',
recording: '錄影釋出',
everyoneContributesPolicy: 'Everyone Contributes Policy',
Expand Down
4 changes: 2 additions & 2 deletions pages/speaking/cfp.vue
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ export default {
isExternalLink: true,
},
{
slot: 'myPyCon',
textKey: 'terms.myPyCon',
slot: 'proposalSystem',
textKey: 'terms.proposalSystem',
url: `https://tw.pycon.org/prs/${this.$i18n.locale}/dashboard`,
isExternalLink: true,
},
Expand Down