Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] remove i18n-unrelated code in provacy-policy page #511

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

mhsiungw
Copy link
Contributor

Types of changes

  • Refactoring

Description

  1. remove unused label: 'https://i.imgur.com/cVjN760.jpg' in i18n/about/privacy-policy.i18n.js
  2. remove i18n-unrelated code terms.contact and move it in template (terms.contact doesn't require translation)
  3. replace (CC BY-SA 3.0 TW) with {licenseTitle} for better maintenance

Related Issue

#499

Additional Context

I was also going to rewrite the styling in pages/about/privacy-policy.vue with respect to #396,
but found that tailwind inline classes will be overridden by ones in I18nPageWrapper.
Maybe we could add important: true in tailwind.config.js to make switching to tailwind css easier?

@mhsiungw mhsiungw added the enhancement New feature or request label Apr 13, 2024
Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for ephemeral-sable-89c7e0 ready!

Name Link
🔨 Latest commit bff7f1f
🔍 Latest deploy log https://app.netlify.com/sites/ephemeral-sable-89c7e0/deploys/661a2e69303b5e0008adb756
😎 Deploy Preview https://deploy-preview-511--ephemeral-sable-89c7e0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@josix
Copy link
Collaborator

josix commented Apr 13, 2024

LGTM, could you help create another PR to propose the change for the CSS coding style refactor, I think that would be easier to have discussion on it~

@mhsiungw
Copy link
Contributor Author

LGTM, could you help create another PR to propose the change for the CSS coding style refactor, I think that would be easier to have discussion on it~

PR #512 has been opened as a POC.
Please have a look at it and tell me what you think, thanks!

@josix josix merged commit 2ec48eb into main Apr 14, 2024
5 checks passed
@josix josix deleted the fix/refactor-privacy-policy-page branch April 14, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants