Addition of lexical resource derived from wikipedia string-matching. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch methods find a valid country, they will return it without trying the slower later methods. Speeds things up massively
|
Ok this looks interesting. Can you add a few test cases to show that your code is working? |
|
Also, please note that I added black styling and rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of lexical resource derived from wikipedia string-matching.
Script to generate the lexical resource is included; has dependency on wikipedia-api package, though this is not required merely to use the prebuild resource (included)
Added matching routine that takes advantage of the lexical resource. The lexical resource is not case-or-accent normalised in case it will become useful at a future time to take advantage of case-variants in scoring matches.