refactor caches #50
Merged
refactor caches #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
The only weird thing in this pull request is that I've moved the "cache" argument into **kwargs and don't specify it explicitly. The reason for that is if we use cache=DictCache() then I think the DictCache() gets instantiated at module load time which means that the tests don't start with a fresh DictCache object each time, thus they have previously cached responses. |
hkraal
reviewed
Nov 6, 2016
| def invalidate(self, key): | ||
| return self._mc.delete(self._hash(key)) | ||
|
|
||
|
|
hkraal
reviewed
Nov 6, 2016
| def invalidate(self, key): | ||
| return self._mc.delete(self._hash(key)) | ||
|
|
||
|
|
||
| class APIConnection(object): |
There was a problem hiding this comment.
2 blank lines before class definition
wtfrank
force-pushed
the
cache-refactor-1
branch
from
6785dbc
to
a9a37e7
Compare
wtfrank
force-pushed
the
cache-refactor-1
branch
from
a9a37e7
to
b54ec0d
Compare
|
I also got rid of some pep issues in the cache.py that I found after running pep8 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move caches into pycrest.cache module
remove cache_dir argument
update documentation about caches