Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle on-off output display #62

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Add toggle on-off output display #62

merged 2 commits into from
Jun 3, 2022

Conversation

arpanbiswas52
Copy link
Contributor

Created an argument on fit function for toggle on-off training output display

Created an argument on fit function for toggle on-off training output display
@arpanbiswas52 arpanbiswas52 reopened this Jun 1, 2022
@ziatdinovmax ziatdinovmax self-requested a review June 1, 2022 23:26
@codecov-commenter
Copy link

Codecov Report

Merging #62 (47c38fa) into master (5fdd8b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   74.86%   74.87%           
=======================================
  Files          63       63           
  Lines        6473     6475    +2     
=======================================
+ Hits         4846     4848    +2     
  Misses       1627     1627           
Flag Coverage Δ
unittests 74.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
atomai/models/dgm/jrvae.py 86.25% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fdd8b2...47c38fa. Read the comment docs.

@ziatdinovmax ziatdinovmax added the enhancement New feature or request label Jun 1, 2022
Copy link
Collaborator

@ziatdinovmax ziatdinovmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Arpan.

A few minor comments
i) I suggest renaming disp into verbose, which is a more common name for this type of argument;
ii) I don't think it has to be an instance attribute as we don't use it anywhere outside fit.

Can you please address them and then I'll approve the merge?

Changes made as per request
@arpanbiswas52
Copy link
Contributor Author

Changes made as per request. Please check once and approve if all look good

@ziatdinovmax ziatdinovmax merged commit 30eab2e into pycroscopy:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants