Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

Replaced time.clock() with time.process_time() #296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabiant7t
Copy link

(time clock was flagged as deprecated in Python 3.3 and got removed in Python 3.8)

Fixes #283

… deprecated in Python 3.3 and got removed in Python 3.8)
@mervick
Copy link

mervick commented Jan 6, 2020

Any progress on this?
Pycrypto does not work with python 3.8 without this changes.

@fabiant7t
Copy link
Author

Any progress on this?
Pycrypto does not work with python 3.8 without this changes.

@mervick I successfully migrated to pycryptodomex

@grtgarrett
Copy link

If I may add a quick suggestion, it would most likely be worth adding a version check to this such as to not break backwards compatibility with older versions of python. IE: if 2.x use clock, if 3.x use process_time. I believe 2.x can not use the process_time function so the check would help here.

@jayvdb
Copy link

jayvdb commented Apr 1, 2020

I adapted this to support Python 2 also as @grtgarrett recommends.
https://build.opensuse.org/request/show/790527

@3v1n0
Copy link

3v1n0 commented Jun 10, 2020

Any pip repo containing this fixed version?

@jayvdb
Copy link

jayvdb commented Jun 11, 2020

pip install git+https://github.com/fabiant7t/pycrypto ?

3v1n0 added a commit to 3v1n0/python-validity that referenced this pull request Jun 11, 2020
It's not released so, we need to rely on the proposed version used by most
distros

pycrypto/pycrypto#296
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time.clock is deprecated - python 3.7
5 participants