Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

Adds a static replacement function via an include file (src/rpl_mallo… #212

Closed
wants to merge 1 commit into from

Conversation

aixtools
Copy link

…c.h) in src/block_template.c

and src/stream_template.c

This concludes part 1 of of issue #209

I expect using an ac.get() call in setup.py to check the value of
to add src/rpl_malloc.c to the sources to be compiled
rather than as a static function that is included multiple times.
However, this seems to fit in the style of how src/*_template.c files
are included in the main files.

…c.h) in src/block_template.c

and src/stream_template.c

This concludes part 1 of of issue #209

I expect using an ac.get() call in setup.py to check the value of
to add src/rpl_malloc.c to the sources to be compiled
rather than as a static function that is included multiple times.
However, this seems to fit in the style of how src/*_template.c files
are included in the main files.
@aixtools
Copy link
Author

The check found what I already knew: including a static function. I could have named the file something.c and maybe it would have passed "lint". Again, I think the better way is to have a separate file and use ac.get() call(s) to add the new file to the extension. I am just too new to "this" to figure it out.

Someone else give a hand - or make a better PR?

@aixtools
Copy link
Author

OK - this is holding back "things". The "travis-ci/pr" test is failing in two, no-longer supported versions of Python (and have never been available, that I know of for AIX).

Summary,
PASS 135.01...135.09
PASS 135.10 Python PYENV_VERSION=2.7.6 preconfigure_args=--without-gmp 3 min 6 sec
FAIL 135.11 Python PYENV_VERSION=3.1.5 2 min 15 sec
FAIL 135.12 Python PYENV_VERSION=3.2.5 2 min 12 sec
PASS 135.13 Python PYENV_VERSION=3.3.5 3 min 9 sec
PASS 135.14 Python PYENV_VERSION=3.4.0 3 min 2 sec
PASS 135.15 Python PYENV_VERSION=3.4.0 preconfigure_args=--without-gmp 3 min 45 sec

It would be "very nice" if this could be accepted. I am quite "young" when it comes to git - so a test I would/could do first is try and "clone" this PR and see if I can build on AIX.

And would do this "manually" for 2.7.X, 3.4.X, 3.5.X and 3.6.X as these are the current versions.

If the "complaint" is because this patch "includes" a (static?) function - just recall I copied existing behavior.

@aixtools
Copy link
Author

As the module is dead, closing.

@aixtools aixtools closed this Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant