This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
fixed all errors from #235 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bilesanmiahmad Rename the venv to env folder since it is already in the .gitignore. Also, add .vscode/settings.json to your global gitignore file (google search how to do this). Your PR and commit should contain only the files that are part of this repo and should not include extra files from your environment. |
|
LGTM @bilesanmiahmad thanks for the changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I resolved all error messages coming from flake8. This included errors like unused imports and long lines beyond 70 characters.