Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LOCAL_APPS before THIRD_PARTY_APPS in INSTALLED_APPS #248

Closed
wants to merge 1 commit into from
Closed

Conversation

aditnryn
Copy link

This allows custom User model to be registered before THIRD_PARTY_APPS are imported.
THIRD_PARTY_APPS can now get the model registered with AUTH_USER_MODEL without throwing a LookupError.

This particular error was seen when using Django-CMS with this cookiecutter.

This allows custom User model to be registered before THIRD_PARTY_APPS are imported.
THIRD_PARTY_APPS can now get the model registered with AUTH_USER_MODEL without throwing a LookupError.
@pydanny
Copy link
Member

pydanny commented Jun 22, 2015

If I remember correctly, I set things up the way they are because the order that they are in works just fine 95% of the time. In fact, it breaks for some packages when the order is switched to the way you designate. Because your fix breaks other packages and is just for the django-cms edge case, I'm going to unfortunately have to reject this PR.

@pydanny pydanny closed this Jun 22, 2015
@pydanny
Copy link
Member

pydanny commented Jun 22, 2015

Have you considered creating your own fork of cookiecutter-django? If you do so, let me know and as long as you maintain it we'll list it in the README.

@aditnryn
Copy link
Author

@pydanny Nice idea. I will maintain a fork with django-cms configured settings. I will post on this thread when the fork is good enough.

@altipard
Copy link

@aditnryn is it good enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants