Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not working for python3.9 #165

Open
letitfly opened this issue Apr 9, 2024 · 1 comment
Open

not working for python3.9 #165

letitfly opened this issue Apr 9, 2024 · 1 comment

Comments

@letitfly
Copy link

letitfly commented Apr 9, 2024

Is your feature request related to a problem? Please describe.
run into error in python3.9
env/lib/python3.9/site-packages/dj_notebook/config_helper.py:12
6 from dotenv import load_dotenv
9 # taken from dotenv, which declares a similar type (but it doesn't look public...)
10 # review note: the | syntax is new in python 3.10. If older pythons are generally being supported here, this should be
11 # rewritten as Union[str, os.PathLike[str]]
---> 12 StrPath = str | os.PathLike[str]
15 def setdefault_calls(module_path: Path) -> Generator[ast.Call, None, None]:
16 """Yields all calls to os.environ.setdefault within a module."""

TypeError: unsupported operand type(s) for |: 'type' and 'types.GenericAlias'

Describe the solution you'd like
will there be support for python 3.9?

@pydanny
Copy link
Owner

pydanny commented Apr 13, 2024

Hey @letitfly, I hadn't planned on supporting Python 3.9. I'm happy to review and merge a PR if you want to submit one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants