Fix for #148: open links in new tab (#157)

pydantic · Feb 7, 2024 · 13a1d46 · 13a1d46
1 parent cec25c6
commit 13a1d46
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/demo/components_list.py b/demo/components_list.py
@@ -78,6 +78,10 @@ class Delivery(BaseModel):
                             components=[c.Text(text='Pydantic (External link)')],
                             on_click=GoToEvent(url='https://pydantic.dev'),
                         ),
+                        c.Link(
+                            components=[c.Text(text='FastUI repo (New tab)')],
+                            on_click=GoToEvent(url='https://github.com/pydantic/FastUI', target='_blank'),
+                        ),
                     ],
                 ),
             ],

diff --git a/src/npm-fastui/src/events.ts b/src/npm-fastui/src/events.ts
@@ -35,7 +35,11 @@ export function useFireEvent(): { fireEvent: (event?: AnyEvent) => void } {
       }
       case 'go-to':
         if (event.url) {
-          location.goto(event.url)
+          if (event.target) {
+            window.open(event.url, event.target)
+          } else {
+            location.goto(event.url)
+          }
         }
         if (event.query) {
           location.setQuery(event.query)

diff --git a/src/npm-fastui/src/models.d.ts b/src/npm-fastui/src/models.d.ts
@@ -141,6 +141,7 @@ export interface GoToEvent {
   query?: {
     [k: string]: string | number
   }
+  target?: '_blank'
   type: 'go-to'
 }
 export interface BackEvent {

diff --git a/src/python-fastui/fastui/events.py b/src/python-fastui/fastui/events.py
@@ -18,6 +18,7 @@ class GoToEvent(BaseModel):
     # can be a path or a full URL
     url: Union[str, None] = None
     query: Union[Dict[str, Union[str, float, None]], None] = None
+    target: Union[Literal['_blank'], None] = None
     type: Literal['go-to'] = 'go-to'