Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data_model=User #124

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Added data_model=User #124

merged 2 commits into from
Dec 28, 2023

Conversation

aekespong
Copy link
Contributor

@aekespong aekespong commented Dec 26, 2023

Solved Issue #126

Modified the code in the sample to latest version where
c.Table[User](
data=users,

has been changed to

c.Table(
data=users,
data_model=User,

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (106d6c5) 94.01% compared to head (7f8a13d) 94.05%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   94.01%   94.05%   +0.04%     
==========================================
  Files          11       11              
  Lines         718      723       +5     
==========================================
+ Hits          675      680       +5     
  Misses         43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hasansezertasan hasansezertasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This syntax is not supported in the current version (0.3.0), so it wouldn't be right to modify this part before the next version is released.

README.md Outdated Show resolved Hide resolved
@samuelcolvin samuelcolvin enabled auto-merge (squash) December 28, 2023 15:30
@samuelcolvin samuelcolvin merged commit 06364c9 into pydantic:main Dec 28, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants