Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix page goto for page 1 #195

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

tim-habitat
Copy link
Contributor

@tim-habitat tim-habitat commented Feb 15, 2024

fixes #142

buttonfix.mov

PR based on the comment: #142 (comment)
however there might have been a reason for the conditional statement that i am not aware of

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (398147e) 95.68% compared to head (b5e6c16) 95.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          14       14           
  Lines         950      950           
=======================================
  Hits          909      909           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hramezani
Copy link
Member

Thanks @tim-habitat

@hramezani hramezani merged commit e1203d6 into pydantic:main Feb 26, 2024
16 checks passed
@tim-habitat tim-habitat deleted the bugfix/page-1-button branch February 27, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pagination component - can't go to page '1'
2 participants