Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON schema tests #70

Merged
merged 10 commits into from
Dec 11, 2023
Merged

JSON schema tests #70

merged 10 commits into from
Dec 11, 2023

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Dec 5, 2023 •
edited
Loading

fixes #18

@samuelcolvin
Copy link
Member Author

waiting for pydantic/pydantic#8320

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (d146572) 100.00% compared to head (bda4007) 96.95%.

❗ Current head bda4007 differs from pull request most recent head e751a62. Consider uploading reports for the commit e751a62 to get more accurate results

Files Patch % Lines
src/python-fastui/tests/test_json_schema_match.py 93.75% 7 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##              main      #70      +/-   ##
===========================================
- Coverage   100.00%   96.95%   -3.05%     
===========================================
  Files            2        3       +1     
  Lines          118      230     +112     
===========================================
+ Hits           118      223     +105     
- Misses           0        7       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelcolvin samuelcolvin marked this pull request as ready for review December 11, 2023 12:44
@samuelcolvin samuelcolvin enabled auto-merge (squash) December 11, 2023 12:44
@samuelcolvin samuelcolvin merged commit e1e4302 into main Dec 11, 2023
14 checks passed
@samuelcolvin samuelcolvin deleted the json-schema-tests branch December 11, 2023 12:45
ischaojie pushed a commit to ischaojie/FastUI that referenced this pull request Dec 11, 2023
@samuelcolvin @ischaojie
JSON schema tests (pydantic#70)
35d5264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON Schema equivalence tests
1 participant
@samuelcolvin