✨ Add codemod and rule to add type annotations or TODO comment for fields with a default and no type annotations #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the same class name
tiangolo
commented
Apr 18, 2024
| " a = 'a'", | ||
| " b = 'b'", | ||
| "", | ||
| "class A(BaseModel):", | ||
| " a: Literal[A.a] = A.a", | ||
| " a: Literal[E.a] = E.a", |
There was a problem hiding this comment.
These tests were failing because both classes had the same name, one would override the other.
And then the new "add type annotations" codemod would modify the enum, just because the name is the same. But as it's not really valid to have the same name for two classes in the same file, I just updated it. 🤓
Kludex
approved these changes
Apr 18, 2024
|
Gracias! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Add codemod and rule to add type annotations or TODO comment for fields with a default and no type annotations
This would fix #149