Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test cases easier to create and understand #76

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 10, 2023

No description provided.

@Kludex
Copy link
Member

Kludex commented Jul 11, 2023

I'm happy to accept any PR like this.

I've found it difficult to find the "best way" to organize the tests. I don't like any way I've created till now, and I've changed it multiple times.

I think the best way would be to have folders, and each folder would be a project, and each file would maybe be a toml, with before, after, the id... Idk...

@cclauss
Copy link
Contributor Author

cclauss commented Jul 11, 2023

toml just puts in all on one line... Not human-readable...

filename = "filename.py"
before = "a\n  b\n    c\n"
after = "x\n  y\n    z\n"

@Kludex
Copy link
Member

Kludex commented Jul 11, 2023

toml just puts in all on one line... Not human-readable...

filename = "filename.py"
before = "a\n  b\n    c\n"
after = "x\n  y\n    z\n"

You can use multiline there, it doesn't need to be like that. 🤔

Anyway, I didn't find the perfect setup yet. 👀

@Kludex
Copy link
Member

Kludex commented Jul 11, 2023

Thanks 🙏

@Kludex Kludex merged commit ca399ab into pydantic:main Jul 11, 2023
7 checks passed
@cclauss cclauss deleted the streamline-tests branch July 11, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants