-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment support #91
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #91 will degrade performances by 24.96%Comparing Summary
Benchmarks breakdown
|
45d4565
to
6110cb2
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
The use case of supporting comments is 👍 from me, but I would like us to find a way to do this without costing performance. I suspect that the introduction of a large match arm inside the The fuzz jobs are failing because serde doesn't support comments. The most practical way to solve both of these may be to make comment support optional and find a way to refactor to avoid the perf hit when unused. |
Hi. But as I don't know rust very much and don't know exactly how this project here is done, I can't write a updated code. |
#90 Add basic comment support