Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logfire_api_session parameter from logfire.configure #272

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

alexmojaki
Copy link
Contributor

Nothing is using this and there's no apparent use case. I think it was there for testing purposes at some point. Now it just adds bloat.

@alexmojaki alexmojaki requested a review from Kludex June 21, 2024 12:25
Copy link

cloudflare-pages bot commented Jun 21, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 078576b
Status: ✅  Deploy successful!
Preview URL: https://51f399a2.logfire-docs.pages.dev
Branch Preview URL: https://alex-remove-logfire-api-sess.logfire-docs.pages.dev

View logs

@alexmojaki alexmojaki enabled auto-merge (squash) June 21, 2024 14:40
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@alexmojaki alexmojaki merged commit 5dbfde4 into main Jun 21, 2024
11 checks passed
@alexmojaki alexmojaki deleted the alex/remove-logfire_api_session branch June 21, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant