-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check token in separate thread #274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. Seems like we never join the thread right? Do have a lock on configure()? What happens if I do;
configure()
while True:
info()
?
Deploying logfire-docs with Cloudflare Pages
|
from logfire import configure, info
configure(token='...')
info('hi')
|
I mean what if it's a valid token. Does that |
The code inside |
Closes #247