logfire.instrument_psycopg() function
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
01d5e1f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2089aa65.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-psycopg.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
alexmojaki
changed the title
logfire.instrument_psycopg() function
PYD-874 Extra `instrument_` methods
We've talked in the new website about:
This has to be done this week since the website will contain it from the first day. |
Kludex
reviewed
Apr 29, 2024
Comment on lines
+842
to
+851
| Args: | ||
| conn_or_module: Can be: | ||
|
|
||
| - The `psycopg` (version 3) or `psycopg2` module. | ||
| - The string `'psycopg'` or `'psycopg2'` to instrument the module. | ||
| - `None` (the default) to instrument whichever module(s) are installed. | ||
| - A `psycopg` or `psycopg2` connection. | ||
|
|
||
| **kwargs: Additional keyword arguments to pass to the OpenTelemetry `instrument` methods, | ||
| particularly `enable_commenter` and `commenter_options`. |
There was a problem hiding this comment.
Does this renders nicely on the API docs?
| from types import ModuleType | ||
| from typing import TYPE_CHECKING, Any | ||
|
|
||
| from packaging.requirements import Requirement |
There was a problem hiding this comment.
Good point, added.
Kludex
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://linear.app/pydantic/issue/PYD-874/extra-instrument-methods