Handle cyclic references in JSON encoding and schema #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
dmontagu
reviewed
Apr 29, 2024
| return _array_schema(obj) | ||
|
|
||
| if id(obj) in seen: | ||
| return {} |
There was a problem hiding this comment.
Suggested change
| return {} | |
| return {'x-circular-reference': True} |
this way we can render something more nicely in the UI for circular references, rather than having it just look like a normal string
There was a problem hiding this comment.
Leaving this for now because it could make the overall schema significantly larger if the data consists only of JSON values which don't need a schema. This can be added if we actually decide to spend time on rendering in the UI.
dmontagu
approved these changes
Apr 29, 2024
alexmojaki
force-pushed
the
alex/recursive-json
branch
from
de1e507
to
33f5348
Compare
Deploying logfire-docs with
|
| Latest commit: |
33f5348
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://441c61ac.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-recursive-json.logfire-docs.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug seen in https://pydanticlogfire.slack.com/archives/C06EDRBSAH3/p1714397069462369