Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recursive dictionaries passed into SchemaValidator result in a panic #62

Closed
adriangb opened this issue May 5, 2022 · 0 comments · Fixed by #67
Closed

recursive dictionaries passed into SchemaValidator result in a panic #62

adriangb opened this issue May 5, 2022 · 0 comments · Fixed by #67

Comments

@adriangb
Copy link
Member

adriangb commented May 5, 2022

For obvious reasons passing in a recursive dict causes a segfault. It's certainly user error, but it might be nice to return a Python RecursionError instead of a segfault

from pydantic_core import SchemaValidator
schema = {"type": "union", "choices": []}
schema['choices'].append(schema)
SchemaValidator(schema)
samuelcolvin added a commit that referenced this issue May 11, 2022
@samuelcolvin
prevent segfault on recursive schema, fix #62
8d2aadb
@samuelcolvin samuelcolvin mentioned this issue May 11, 2022
Merged
samuelcolvin added a commit that referenced this issue May 11, 2022
@samuelcolvin
prevent segfault on recursive schema (#67)
e50eecc 
* prevent segfault on recursive schema, fix #62

* linting

* use RecursionError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prevent segfault on recursive schema pydantic/pydantic-core
1 participant
@adriangb