Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump serde from 1.0.189 to 1.0.190 #1047

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 30, 2023

Bumps serde from 1.0.189 to 1.0.190.

Release notes

Sourced from serde's releases.

v1.0.190

  • Preserve NaN sign when deserializing f32 from f64 or vice versa (#2637)
Commits
  • edb1a58 Release 1.0.190
  • 11c2917 Merge pull request #2637 from dtolnay/nansign
  • 6ba9c12 Float copysign does not exist in libcore yet
  • d2fcc34 Ensure f32 deserialized from f64 and vice versa preserve NaN sign
  • a091a07 Add float NaN tests
  • bb4135c Fix unused imports
  • 8de84b7 Resolve get_first clippy lint
  • 9cdf332 Remove 'remember to update' reminder from Cargo.toml
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [serde](https://github.com/serde-rs/serde) from 1.0.189 to 1.0.190.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.189...v1.0.190)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1047 (b68cd5d) into main (866eb2d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files         106      106           
  Lines       15975    15975           
  Branches       35       35           
=======================================
  Hits        14878    14878           
  Misses       1090     1090           
  Partials        7        7           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 866eb2d...b68cd5d. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 30, 2023

CodSpeed Performance Report

Merging #1047 will degrade performances by 24.67%

Comparing dependabot/cargo/serde-1.0.190 (b68cd5d) with main (866eb2d)

Summary

❌ 2 regressions
✅ 138 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dependabot/cargo/serde-1.0.190 Change
test_dont_raise_error 29.2 µs 38.4 µs -24.03%
test_decimal_from_string_core 53.5 µs 71 µs -24.67%

@davidhewitt davidhewitt merged commit 73c431b into main Nov 6, 2023
29 of 30 checks passed
@davidhewitt davidhewitt deleted the dependabot/cargo/serde-1.0.190 branch November 6, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant