Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce dependabot frequency #1059

Merged
merged 1 commit into from
Nov 6, 2023
Merged

reduce dependabot frequency #1059

merged 1 commit into from
Nov 6, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Nov 6, 2023

Change Summary

From weekly to monthly, as we're picking up a lot of noise from dependabot updates of test deps.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1059 (5c8c31f) into main (1f18da2) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files         104      104           
  Lines       15812    15812           
  Branches       35       35           
=======================================
  Hits        14747    14747           
  Misses       1058     1058           
  Partials        7        7           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f18da2...5c8c31f. Read the comment docs.

Copy link

codspeed-hq bot commented Nov 6, 2023

CodSpeed Performance Report

Merging #1059 will degrade performances by 12.54%

Comparing dh/less-dependabot (5c8c31f) with main (1f18da2)

Summary

❌ 1 regressions
✅ 139 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/less-dependabot Change
test_decimal_from_string_core 67.4 µs 77.1 µs -12.54%

@davidhewitt
Copy link
Contributor Author

please review

@samuelcolvin samuelcolvin merged commit 5de6b75 into main Nov 6, 2023
28 of 30 checks passed
@samuelcolvin samuelcolvin deleted the dh/less-dependabot branch November 6, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants