Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation of negative floats when using multiple_of #1077

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Nov 16, 2023

Change Summary

Fixes pydantic/pydantic#8154

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1077 (920324a) into main (2f0c8c2) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1077   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         106      106           
  Lines       16397    16397           
  Branches       35       35           
=======================================
  Hits        14698    14698           
  Misses       1692     1692           
  Partials        7        7           
Files Coverage Δ
src/validators/float.rs 90.44% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0c8c2...920324a. Read the comment docs.

Copy link

codspeed-hq bot commented Nov 16, 2023

CodSpeed Performance Report

Merging #1077 will not alter performance

Comparing Viicos:8154-multiple-of (920324a) with main (2f0c8c2)

Summary

✅ 140 untouched benchmarks

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; will rebase to fix the lint issue and merge!

@davidhewitt davidhewitt enabled auto-merge (squash) November 17, 2023 09:43
@davidhewitt davidhewitt merged commit ca83d24 into pydantic:main Nov 17, 2023
29 checks passed
@Viicos Viicos deleted the 8154-multiple-of branch November 17, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotated type using multiple_of does not correctly validate negitive numbers
2 participants