Update ci for Rust 1.74 #1079
Merged
Update ci for Rust 1.74 #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Nov 17, 2023
Comment on lines
109
to
113
| cargo clippy --tests -- \ | ||
| -D warnings \ | ||
| -W clippy::pedantic \ | ||
| -W clippy::dbg_macro \ | ||
| -W clippy::print_stdout \ | ||
| -A clippy::cast-possible-truncation \ | ||
| -A clippy::cast-possible-wrap \ |
There was a problem hiding this comment.
I wasn't able to move the rest of these lints to the Cargo.toml, see rust-lang/rust-clippy#11830
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 106 106
Lines 16397 16397
Branches 35 35
=======================================
Hits 14698 14698
Misses 1692 1692
Partials 7 7 Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #1079 will improve performances by 23.44%Comparing Summary
Benchmarks breakdown
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Lint fixes in CI for Rust 1.74. No change of behaviour.
Related issue number
N/A
Checklist
pydantic-core(except for expected changes)