-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tuple validator #73
Tuple validator #73
Conversation
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 93.45% 93.78% +0.32%
==========================================
Files 39 40 +1
Lines 3301 3491 +190
Branches 24 26 +2
==========================================
+ Hits 3085 3274 +189
- Misses 216 217 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looking good.
…to tuple-validator
@samuelcolvin @PrettyWood ready for re-review 🙏 |
This PR also fixes CI Lint failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looking good.
otherwise this looks great, just a few things to fix. |
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
I've made a few changes - hope that's okay. Only think remaining is to improve the coverage. |
Of course!
Can we merge this one, and I'd do that in new PR, covering more than just tuple? |
Best to get That's the only file with missing coverage. |
Done ... I believe |
Wonderful, I'll look soon. |
This is great, thank you so much. 🙏 |
* fix heterogenious error context, ref #73 * linting and correct trait order
Part of #9