Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuple validator #73

Merged
merged 27 commits into from
Jun 16, 2022
Merged

Tuple validator #73

merged 27 commits into from
Jun 16, 2022

Conversation

czotomo
Copy link
Contributor

@czotomo czotomo commented May 17, 2022

Part of #9

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #73 (14008f2) into main (17d4a54) will increase coverage by 0.32%.
The diff coverage is 97.87%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   93.45%   93.78%   +0.32%     
==========================================
  Files          39       40       +1     
  Lines        3301     3491     +190     
  Branches       24       26       +2     
==========================================
+ Hits         3085     3274     +189     
- Misses        216      217       +1     
Impacted Files Coverage Δ
src/errors/kinds.rs 100.00% <ø> (ø)
src/validators/tuple.rs 97.35% <97.35%> (ø)
pydantic_core/_types.py 100.00% <100.00%> (ø)
src/input/input_abstract.rs 100.00% <100.00%> (ø)
src/input/input_json.rs 96.94% <100.00%> (+1.74%) ⬆️
src/input/input_python.rs 93.19% <100.00%> (+0.88%) ⬆️
src/validators/mod.rs 98.29% <100.00%> (+0.02%) ⬆️
src/validators/model_class.rs 97.82% <100.00%> (ø)
src/validators/dict.rs 77.90% <0.00%> (+0.79%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d4a54...14008f2. Read the comment docs.

pydantic_core/_types.py Outdated Show resolved Hide resolved
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looking good.

pydantic_core/_types.py Outdated Show resolved Hide resolved
pydantic_core/_types.py Outdated Show resolved Hide resolved
src/validators/tuple.rs Outdated Show resolved Hide resolved
@czotomo
Copy link
Contributor Author

czotomo commented Jun 14, 2022

@samuelcolvin @PrettyWood ready for re-review 🙏

@czotomo
Copy link
Contributor Author

czotomo commented Jun 14, 2022

This PR also fixes CI Lint failure

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looking good.

pydantic_core/_types.py Outdated Show resolved Hide resolved
src/validators/tuple.rs Outdated Show resolved Hide resolved
src/validators/tuple.rs Outdated Show resolved Hide resolved
src/validators/tuple.rs Outdated Show resolved Hide resolved
src/validators/tuple.rs Show resolved Hide resolved
@samuelcolvin
Copy link
Member

otherwise this looks great, just a few things to fix.

czotomo and others added 3 commits June 15, 2022 21:45
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
@samuelcolvin
Copy link
Member

I've made a few changes - hope that's okay.

Only think remaining is to improve the coverage.

@czotomo
Copy link
Contributor Author

czotomo commented Jun 15, 2022

I've made a few changes - hope that's okay.

Of course!

Only think remaining is to improve the coverage.

Can we merge this one, and I'd do that in new PR, covering more than just tuple?

@samuelcolvin
Copy link
Member

Best to get tuple.rs coverage fixed in this PR.

That's the only file with missing coverage.

@czotomo
Copy link
Contributor Author

czotomo commented Jun 16, 2022

Best to get tuple.rs coverage fixed in this PR.

That's the only file with missing coverage.

Done ... I believe

@samuelcolvin
Copy link
Member

Wonderful, I'll look soon.

@samuelcolvin samuelcolvin merged commit d6ee7b4 into pydantic:main Jun 16, 2022
@samuelcolvin
Copy link
Member

This is great, thank you so much. 🙏

samuelcolvin added a commit that referenced this pull request Jun 16, 2022
@samuelcolvin samuelcolvin mentioned this pull request Jun 16, 2022
samuelcolvin added a commit that referenced this pull request Jun 16, 2022
* fix heterogenious error context, ref #73

* linting and correct trait order
@PrettyWood PrettyWood mentioned this pull request Jun 18, 2022
12 tasks
@czotomo czotomo deleted the tuple-validator branch November 1, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants