improve quality of too short / too long error messages

[davidhewitt]

Change Summary

Reverts part of #902 as per pydantic/pydantic#7613 (comment)

Related issue number

Fixes pydantic/pydantic#7613

Checklist

• Unit tests for the changes exist
• Documentation reflects the changes where applicable
• Pydantic tests pass with this pydantic-core (except for expected changes)
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

[davidhewitt]

please review

[codecov]

Codecov Report

Merging #990 (25bb43c) into main (e610984) will decrease coverage by 0.01%.
The diff coverage is 97.36%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   92.99%   92.98%   -0.01%     
==========================================
  Files         106      106              
  Lines       15844    15827      -17     
  Branches       35       35              
==========================================
- Hits        14734    14717      -17     
  Misses       1103     1103              
  Partials        7        7              

Files	Coverage Δ
src/errors/types.rs	99.66% <100.00%> (+<0.01%)	⬆️
src/input/return_enums.rs	84.93% <100.00%> (-0.46%)	⬇️
src/validators/generator.rs	90.94% <100.00%> (ø)
src/validators/list.rs	100.00% <ø> (ø)
src/validators/tuple.rs	94.32% <88.88%> (-0.03%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e610984...25bb43c. Read the comment docs.

[codspeed-hq]

CodSpeed Performance Report

Merging #990 will degrade performances by 12.01%

_{Comparing dh/generators (25bb43c) with main (e610984)}

Summary

❌ 1 regressions
✅ 137 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	dh/generators	Change
❌	test_variable_tuple	34.8 µs	39.5 µs	-12.01%

[davidhewitt]

Pushed a second commit to rework error messages as requested by @samuelcolvin.

[samuelcolvin]

LGTM.

Do we want anyone else to check it? Otherwise i'm happy to merge.