-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hypothesis plugin #34
Comments
Hey @hirotasoshu I appreciate your input, but I disagree because there are various types available such as PostgreSQL, MySQL, Emailstr, and other commonly used types including the Hypothesis plugin. IMO, it would be more beneficial for these types to remain within Pydantic for now. I guess @samuelcolvin @dmontagu will agree with me about that |
I think with V2 we probably won't need the hypothesis plugin for most things, well need some compatibility on a few types. |
+1 working on them to make bunch of stuff ready |
@yezz123 I'm sorry, I think I put it wrong. I didn't mean to transfer the entire pydantic hypothesis plugin into this package. I just wanted hypothesis to work with pydantic-extra-types because the current implementation of the hypothesis plugin only registers pydantic types. I was thinking of two options:
@samuelcolvin will this work for types that have complex validation? For example, for card numbers (luhn algorithm).If so, then this issue doesn't make sense) |
See annotated-types/annotated-types#37. Ideally we don't need any hypothesis plugins. |
Oh, I see, thanks for the clarification) |
See pydantic#34 for details
Since this is separate package, hypothesis plugin for pydantic will not work for this types.
Instead of making a separate plugin, support for pydantic-extra-types can be added to the pydantic hypothesis plugin as part of pydantic/pydantic#4682.
The text was updated successfully, but these errors were encountered: