Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotenv no error w/ an env key shorter than prefix (#106) #107

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

jvllmr
Copy link
Contributor

@jvllmr jvllmr commented Jul 5, 2023

fixes #106

I created a test that tests a dotenv config class with a prefix to test the effect of my changes

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (373af71) 97.42% compared to head (1be08cc) 97.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files           5        5           
  Lines         311      311           
  Branches       68       68           
=======================================
  Hits          303      303           
  Misses          6        6           
  Partials        2        2           
Impacted Files Coverage Δ
pydantic_settings/sources.py 97.70% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hramezani
Copy link
Member

Thanks @jvllmr

@hramezani hramezani merged commit 994f4ec into pydantic:main Jul 5, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DotEnv ValueError when env variable name is shorter than env_prefix
2 participants