Add documentation about compatibility with pydantic 1.x BaseSettings when using dotenv #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when using dotenv
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 5 5
Lines 313 313
Branches 68 68
=======================================
Hits 305 305
Misses 6 6
Partials 2 2 ☔ View full report in Codecov by Sentry. |
hramezani
changed the title
hramezani
reviewed
Jul 13, 2023
hramezani
reviewed
Jul 13, 2023
hramezani
reviewed
Jul 13, 2023
hramezani
approved these changes
Jul 13, 2023
|
Thanks @SthPhoenix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when using dotenv
This PR adds more info about compatibility with old behavior, since in current version
extraseems to be defaulted toforbid, which broke behavior expected in pydantic 1.x BaseSettings.More info: #125