Separate decoding of complex values into specific method #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 97.44% 97.46% +0.01%
==========================================
Files 5 5
Lines 313 315 +2
Branches 68 68
==========================================
+ Hits 305 307 +2
Misses 6 6
Partials 2 2
☔ View full report in Codecov by Sentry. |
|
please review |
hramezani
reviewed
Jul 14, 2023
dbendall
force-pushed
the
db/non-json-complex-fields
branch
from
e1a9349
to
bad9c81
Compare
hramezani
approved these changes
Jul 14, 2023
|
Thanks @dbendall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Separates decoding of complex values into a specific method in settings sources to allow for easier customisation of complex environment variable parsing whilst retaining the ability to parse nested and non-complex fields.
Related issue number
Feature request #126
Selected Reviewer: @hramezani