Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old code relatd to optional dotenv #155

Merged
merged 1 commit into from Sep 4, 2023
Merged

Remove old code relatd to optional dotenv #155

merged 1 commit into from Sep 4, 2023

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Aug 29, 2023

Related to #149

Selected Reviewer: @samuelcolvin

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (919a20b) 97.47% compared to head (1141792) 97.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   97.47%   97.45%   -0.03%     
==========================================
  Files           5        5              
  Lines         317      314       -3     
  Branches       69       69              
==========================================
- Hits          309      306       -3     
  Misses          6        6              
  Partials        2        2              
Files Changed Coverage Δ
pydantic_settings/sources.py 97.70% <100.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hramezani
Copy link
Member Author

please review

@hramezani hramezani merged commit 0226fe2 into main Sep 4, 2023
20 checks passed
@hramezani hramezani deleted the dotenv branch September 4, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants