Fix dotenv source extra values parsing provided in dotenv file #221
+59
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
- Coverage 97.63% 97.63% -0.01%
==========================================
Files 5 5
Lines 423 422 -1
Branches 89 89
==========================================
- Hits 413 412 -1
Misses 7 7
Partials 3 3 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 26, 2024
hramezani
force-pushed
the
dotenv-source-extra
branch
from
3ee3480
to
4800f55
Compare
hramezani
force-pushed
the
dotenv-source-extra
branch
from
4800f55
to
494bf99
Compare
samuelcolvin
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
LGTM.
But ideally it would be great if @gsakkis could review this and confirm it fixes their problem?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fiexes #219 and #220