Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore env_prefix if validation_alias is set #25

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Apr 26, 2023

Found this when checking #14
This was the behavior in V1 and changed by mistake in V2.
Also, I've updated the docs pr regarding this 6a29a7d

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (eb6ed32) 95.61% compared to head (dfbc683) 95.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files           5        5           
  Lines         251      251           
  Branches       60       60           
=======================================
  Hits          240      240           
  Misses         10       10           
  Partials        1        1           
Impacted Files Coverage Δ
pydantic_settings/sources.py 95.63% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samuelcolvin samuelcolvin merged commit 6d9c1a2 into pydantic:main Apr 27, 2023
18 checks passed
@hramezani hramezani deleted the env_prefix_validation_alias branch April 27, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants