Change the behavior of field_is_complex to be more similar to pydantic v1 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 95.91% 96.00% +0.08%
==========================================
Files 5 5
Lines 269 275 +6
Branches 66 67 +1
==========================================
+ Hits 258 264 +6
Misses 10 10
Partials 1 1
☔ View full report in Codecov by Sentry. |
dmontagu
force-pushed
the
improve-field-complex
branch
3 times, most recently
from
1a62c7b
to
4f02775
Compare
dmontagu
force-pushed
the
improve-field-complex
branch
from
0683d4b
to
6275726
Compare
hramezani
reviewed
Apr 27, 2023
|
Thanks @dmontagu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this discrepancy while helping Sebastian with FastAPI. @hramezani I'll defer to you whether the change makes sense. Feel free to modify the implementation, add tests, etc. Or request that I do it 😄