Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enhancements to the index.md #73

Merged
merged 6 commits into from
Jun 14, 2023
Merged

Add enhancements to the index.md #73

merged 6 commits into from
Jun 14, 2023

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Jun 9, 2023

Closes DOC-60

Selected Reviewer: @dmontagu

@Kludex
Copy link
Member Author

Kludex commented Jun 9, 2023

please review

@linear
Copy link

linear bot commented Jun 9, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.68 ⚠️

Comparison is base (c05410f) 97.32% compared to head (36b5f17) 95.65%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   97.32%   95.65%   -1.68%     
==========================================
  Files           5        5              
  Lines         299      299              
  Branches       67       67              
==========================================
- Hits          291      286       -5     
- Misses          6        9       +3     
- Partials        2        4       +2     
Impacted Files Coverage Δ
pydantic_settings/__init__.py 100.00% <100.00%> (ø)
pydantic_settings/main.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@dmontagu dmontagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@Kludex
Copy link
Member Author

Kludex commented Jun 13, 2023

please review

@Kludex Kludex requested a review from dmontagu June 13, 2023 15:15
@Kludex Kludex enabled auto-merge (squash) June 14, 2023 11:38
@Kludex Kludex merged commit dba60fe into main Jun 14, 2023
18 checks passed
@Kludex Kludex deleted the docs/review branch June 14, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants