Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docs from Pydantic #8

Closed
wants to merge 1 commit into from
Closed

Conversation

hramezani
Copy link
Member

  • Move Pydantic docs/usage/settings to this repo under docs/inxex.md
  • Added docs reqirements
  • Make the make docs command works and generate the doc

There is no change in the content and content has to be adjusted

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4e83f45) compared to base (79571e3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              main        #8    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         2     -1     
  Lines          194         7   -187     
  Branches        53         0    -53     
==========================================
- Hits           194         7   -187     
Impacted Files Coverage Δ
pydantic_settings/main.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samuelcolvin
Copy link
Member

@hramezani @PrettyWood what do you think long term? Should we have a separate docs site for pydantic-settings?

I'm wondering about have a separate repo for docs which includes the docs for all parts of pydantic - they're so closely connected that I think they should probably be on the sam domain.

@hramezani
Copy link
Member Author

hmmm, didn't think about this. but yeah. I would say it's a good idea to have them in the same domain.
Then we need to just change the usage/settings page content of Pydantic docs later after we released V2.

I close this one.

@hramezani hramezani closed this Oct 11, 2022
@samuelcolvin
Copy link
Member

Agreed, I think that's the best solution long term. Lots to do, but we'll get there.

@hramezani hramezani deleted the init_docs branch October 11, 2022 21:57
@hramezani
Copy link
Member Author

So, in this case, if we add/change something in pedantic-settings. Then we need to update the doc in pydantic repo?
One PR for change and one PR for doc? Or?

@samuelcolvin
Copy link
Member

Well, either we keep the docs in each repo, then somehow combine them somehow (perhaps via submodules) in a new repo pydantic-docs which takes care of building and publishing docs. Which is kind of complicated, but means you can update docs and code in the same PR.

Or, we move all docs (except docstrings obviously) to a new pydanitc-docs repo, and just accept that any change which requires changes to docs requires a companion PR on pydantic-docs.

Thinking about it now, it sounds like the first option would probably be preferable, even if it requires a little more setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants