Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code block formatting #89

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Fix code block formatting #89

merged 2 commits into from
Jun 26, 2023

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Jun 26, 2023

Fixes #88

Output after this patch

pic

@hramezani hramezani requested a review from Kludex June 26, 2023 08:22
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did what I did, so there was less text on the snippet.

Should we highlight the lines? https://squidfunk.github.io/mkdocs-material/reference/code-blocks/#highlighting-specific-lines

In any case, I'm fine with this.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1cf2073) 97.42% compared to head (41f72f8) 97.42%.

❗ Current head 41f72f8 differs from pull request most recent head 35a1bee. Consider uploading reports for the commit 35a1bee to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files           5        5           
  Lines         311      311           
  Branches       68       68           
=======================================
  Hits          303      303           
  Misses          6        6           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hramezani hramezani force-pushed the fix_code_blocks branch 4 times, most recently from 452e280 to 2ae7372 Compare June 26, 2023 08:55
@hramezani
Copy link
Member Author

Thanks @Kludex for your suggestion.

Highlight added to some lines.

@hramezani hramezani enabled auto-merge (squash) June 26, 2023 08:58
@hramezani hramezani merged commit 584a57b into main Jun 26, 2023
18 checks passed
@hramezani hramezani deleted the fix_code_blocks branch June 26, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badly formatted code blocks garble up docs
3 participants