Skip to content

Commit

Permalink
Remove benchmarks completely (#3973)
Browse files Browse the repository at this point in the history
* removing benchmarks completely

* [no ci] add change
  • Loading branch information
samuelcolvin committed Apr 4, 2022
1 parent b25e22f commit 8997cc5
Show file tree
Hide file tree
Showing 20 changed files with 5 additions and 892 deletions.
25 changes: 1 addition & 24 deletions .github/workflows/ci.yml
Expand Up @@ -255,32 +255,9 @@ jobs:
- name: test
run: make test-fastapi

benchmark:
name: run benchmarks
runs-on: ubuntu-latest
env:
BENCHMARK_REPEATS: 1

steps:
- uses: actions/checkout@v3

- name: set up python
uses: actions/setup-python@v3
with:
python-version: '3.8'

- name: install and build
run: |
make build
make install-benchmarks
- run: make benchmark-pydantic
- run: make benchmark-all
- run: make benchmark-json

build:
name: build py3.${{ matrix.python-version }} on ${{ matrix.platform || matrix.os }}
needs: [lint, test-linux, test-windows-mac, test-old-mypy, test-fastapi, benchmark]
needs: [lint, test-linux, test-windows-mac, test-old-mypy, test-fastapi]
if: "success() && (startsWith(github.ref, 'refs/tags/') || github.ref == 'refs/heads/master')"
strategy:
fail-fast: false
Expand Down
16 changes: 0 additions & 16 deletions Makefile
Expand Up @@ -21,10 +21,6 @@ install-testing: install-pydantic
install-docs: install-pydantic
pip install -U -r docs/requirements.txt

.PHONY: install-benchmarks
install-benchmarks: install-pydantic
pip install -U -r benchmarks/requirements.txt

.PHONY: install
install: install-testing install-linting install-docs
@echo 'installed development requirements'
Expand Down Expand Up @@ -85,18 +81,6 @@ test-fastapi:
.PHONY: all
all: lint mypy testcov

.PHONY: benchmark-all
benchmark-all:
python benchmarks/run.py

.PHONY: benchmark-pydantic
benchmark-pydantic:
python benchmarks/run.py pydantic-only

.PHONY: benchmark-json
benchmark-json:
TEST_JSON=1 python benchmarks/run.py

.PHONY: clean
clean:
rm -rf `find . -name __pycache__`
Expand Down
39 changes: 0 additions & 39 deletions benchmarks/profile.py

This file was deleted.

14 changes: 0 additions & 14 deletions benchmarks/requirements.txt

This file was deleted.

0 comments on commit 8997cc5

Please sign in to comment.