Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put back coverage at 100% #2367

Closed
PrettyWood opened this issue Feb 15, 2021 · 1 comment · Fixed by #2368
Closed

Put back coverage at 100% #2367

PrettyWood opened this issue Feb 15, 2021 · 1 comment · Fixed by #2368
Labels
Meta

Comments

@PrettyWood
Copy link
Member

Just saw that. Can have a look tonight
@PrettyWood PrettyWood added the bug V1 Bug related to Pydantic V1.X label Feb 15, 2021
@samuelcolvin
Copy link
Member

Yes saw it too, I'll try today if I have time, otherwise I'll wait for your PR.

samuelcolvin added a commit that referenced this issue Feb 15, 2021
@samuelcolvin
fixing coverage by simplifying Annotated import logic, fix #2367
50a6915
@samuelcolvin samuelcolvin added Meta and removed bug V1 Bug related to Pydantic V1.X labels Feb 15, 2021
@samuelcolvin samuelcolvin mentioned this issue Feb 15, 2021
Merged
samuelcolvin added a commit that referenced this issue Feb 17, 2021
@samuelcolvin
fix coverage and make typing-extensions a required dependency (#2368)
b7a8ef2 
* fixing coverage by simplifying Annotated import logic, fix #2367

* avoid checking against annotated if it's None

* make typing-extensions required WIP

* more making typing-extensions required

* fix docs and get_origin for python 3.6

* fix mypy test

* fix docs

* update docs, cleanup and add change

* clean docs/examples/schema_annotated.py

* move AnnotatedTypeNames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix coverage and make typing-extensions a required dependency pydantic/pydantic
2 participants
@samuelcolvin @PrettyWood