add py.typed marker file for PEP-561 support #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pydantic#390 Disable zip_safe option as mypy is incompatible with it.
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 2000 2000
Branches 375 375
=====================================
Hits 2000 2000 |
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
…in CoreSchema types (pydantic#391) * Update documentation of some of CoreSchema function arguments * Apply suggestions from code review Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Samuel Colvin <s@muelcolvin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
PEP-561 specifies way for packages to mark them as having type information. As of v0.19 pydantic has improved inline type hints which can be utilized by mypy and similar tools.
Running
python setup.py sdist bdist_wheelincludes thepy.typedfile in both distributions.HISTORY.rst changes needed for this, or something else missing?
Related issue number
Closes #390
Checklist
HISTORY.rsthas been updated#<number>@<whomever>