Subclass abcmeta #123
Merged
Subclass abcmeta #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 852 853 +1
Branches 191 191
=====================================
+ Hits 852 853 +1 |
samuelcolvin
requested changes
Feb 2, 2018
Makefile
Outdated
| @@ -19,7 +19,7 @@ lint: | |||
|
|
|||
| .PHONY: test | |||
| test: | |||
| pytest --cov=pydantic | |||
There was a problem hiding this comment.
remove these changes, the problem should be fixed by Teemu/pytest-sugar#133 which will hopefully be merged soon.
If the problems persist I'll remove pytest-sugar completely.
|
What kind of documentation are you thinking about? Since it's in the stdlib the documentation is already there: https://docs.python.org/3/library/abc.html Maybe just a mention in the changelog? |
|
Just a show section in the main docs saying something like "pydantic works with python's standard abc" then a mini example in python. |
|
Tests are failing since I readded |
|
Looks great. Thank you very much. I'll wait a couple of days in the hope that pytest-sugar gets fixed, if it doesn't I'll remove it. Once that's done this looks ready to merge. |
|
great, thank you very much. |
tpdorsey
added a commit
that referenced
this pull request
May 2, 2023
Expands docstring coverage for #5568 ## Change Summary <!-- Please give a short summary of the changes. --> ## Related issue number <!-- Are there any issues opened that will be resolved by merging this change? --> <!-- WARNING: please use "fix #123" style references so the issue is closed when this PR is merged. --> ## Checklist * [ ] Unit tests for the changes exist * [ ] Tests pass on CI and coverage remains at 100% * [x] Documentation reflects the changes where applicable * [ ] `changes/<pull request or issue id>-<github username>.md` file added describing change (see [changes/README.md](https://github.com/samuelcolvin/pydantic/blob/master/changes/README.md) for details) * [ ] My PR is ready to review, **please add a comment including the phrase "please review" to assign reviewers**
tpdorsey
added a commit
that referenced
this pull request
May 3, 2023
Expands docstring and moves page in API docs to preserve alpha ordering ## Change Summary <!-- Please give a short summary of the changes. --> ## Related issue number <!-- Are there any issues opened that will be resolved by merging this change? --> <!-- WARNING: please use "fix #123" style references so the issue is closed when this PR is merged. --> ## Checklist * [ ] Unit tests for the changes exist * [ ] Tests pass on CI and coverage remains at 100% * [x] Documentation reflects the changes where applicable * [ ] `changes/<pull request or issue id>-<github username>.md` file added describing change (see [changes/README.md](https://github.com/samuelcolvin/pydantic/blob/master/changes/README.md) for details) * [ ] My PR is ready to review, **please add a comment including the phrase "please review" to assign reviewers** Selected Reviewer: @dmontagu
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
* add complete benchmark * fixing tests * extending benchmarks * tweaks and test readme * skip complete benchmarks for <py3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented what we discussed in #120
Also changed pytest execution in the Makefile (was failing in my machine).