Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark of validx library #1810

Closed
wants to merge 5 commits into from

Conversation

mathbeal
Copy link

@mathbeal mathbeal commented Aug 7, 2020

Comparing similar libraries is encouraged on pydantic benchmark page https://pydantic-docs.helpmanual.io/benchmarks/

Change Summary

Related issue number

closes #1816

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #1810 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1810   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3895      3895           
  Branches       783       783           
=========================================
  Hits          3895      3895           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44616e3...3d17e1e. Read the comment docs.

Co-authored-by: PrettyWood <em.jolibois@gmail.com>
@samuelcolvin
Copy link
Member

Sorry for the slow response, and sorry to disappoint, but I'm afraid I'm not accepting benchmarks for libraries that are significantly less popular than pydantic itself, see #1939 (comment) for an explanation, see also #1525.

Now that I've made that rule and refused a number of other libraries, I can't really accept validx.

@samuelcolvin
Copy link
Member

samuelcolvin commented Oct 9, 2020

happy to accept a tweak to the wording on the benchmarks page to make this clear, so people don't waste their time.

I feel really bad closing pull requests like this. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark pydantic with validx library
3 participants