New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark of validx library #1810
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1810 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3895 3895
Branches 783 783
=========================================
Hits 3895 3895 Continue to review full report at Codecov.
|
Co-authored-by: PrettyWood <em.jolibois@gmail.com>
Sorry for the slow response, and sorry to disappoint, but I'm afraid I'm not accepting benchmarks for libraries that are significantly less popular than pydantic itself, see #1939 (comment) for an explanation, see also #1525. Now that I've made that rule and refused a number of other libraries, I can't really accept validx. |
happy to accept a tweak to the wording on the benchmarks page to make this clear, so people don't waste their time. I feel really bad closing pull requests like this. 🙏 |
Comparing similar libraries is encouraged on pydantic benchmark page https://pydantic-docs.helpmanual.io/benchmarks/
Change Summary
Related issue number
closes #1816
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)