gt, lt, #188
Merged
gt, lt, #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1036 1036
Branches 214 214
=====================================
Hits 1036 1036 |
Gr1N
reviewed
Jun 2, 2018
tests/test_types.py
Outdated
| @@ -836,3 +836,27 @@ class Model(BaseModel): | |||
| assert exc_info.value.flatten_errors() == result | |||
| else: | |||
| assert Model(foo=value).foo == result | |||
|
|
|||
|
|
|||
| def test_gt(): | |||
There was a problem hiding this comment.
maybe better to name test_number_gt and test_number_lt?
Gr1N
reviewed
Jun 2, 2018
| with pytest.raises(ValidationError) as exc_info: | ||
| Model(a=-1) | ||
| assert ( | ||
| 'ensure this value is greater than -1 (type=value_error.number.gt; limit_value=-1)' |
There was a problem hiding this comment.
why you want to use string representation of errors not .flatten_errors() like in all other tests?
There was a problem hiding this comment.
I was just doing the quickest thing, doing it various different ways in tests is a good thing.
|
👍 |
samuelcolvin
added a commit
that referenced
this pull request
Jun 6, 2018
Merged
samuelcolvin
added a commit
that referenced
this pull request
Jun 7, 2018
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
* improve tuple schema definition * add "mode" to tuple schema * made "mode" optinonal on variable tuples * tweak enum names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #176