-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make dict validator strict by default #2211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2211 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 4121 4121
Branches 829 830 +1
=========================================
Hits 4121 4121
Continue to review full report at Codecov.
|
I think a feature flag for this is too confusing. We should just wait for v2, hopefully not too long now. I'm really hoping to make some time to do the refactoring required for v2 in january. |
Glad to read that! Don't hesitate if we can help :) |
I'm always happy to accept a PR to improve documentation. I'm just hesitant to make fundamental behaviour changes (even behind feature flags) within v1, especially since I think we're approaching the end of the v1 lifespan. |
4f6ad91
to
8e18ad1
Compare
@PrettyWood @samuelcolvin here are some slightly less intrusive tweaks that would fix the bugs while retaining the existing behavior of being able to parse a dict from a list of tuples... would it make sense to add something like one of these before v2? #2513 (comment) I would be happy to submit a PR (if desired), or not, if I hear either an affirmative or a negative response, respectively... |
fixed in v2, omit for v1.10 |
Change Summary
Make the
dict_validator
strict by default.Add a way to keep old behaviour with
loose_dict_validator
flag inBaseConfig
Related issue number
closes #1268
closes #1982
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)