-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds benchmark tests for Schematics tool #2381
Adds benchmark tests for Schematics tool #2381
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2381 +/- ##
===========================================
- Coverage 100.00% 99.90% -0.10%
===========================================
Files 23 25 +2
Lines 4485 5072 +587
Branches 909 1038 +129
===========================================
+ Hits 4485 5067 +582
- Misses 0 1 +1
- Partials 0 4 +4
Continue to review full report at Codecov.
|
Normally I refuse new benchmarks, but I do see that this library is relatively popular. Could you give a summary of the benchmark results with this added? I'm afraid I don't have a linux machine at hand right now. |
benchmarks/test_schematics.py
Outdated
try: | ||
obj = self.model(data) | ||
return True, obj.validate() | ||
except Exception as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surely not all exceptions should be caught here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I've already corrected.
@samuelcolvin i don't have a linux machine too. But this is the results executed on a Mac Pro with MacOS Catalina, i5 2GHZ, 16GB.
|
Change Summary
This PR adds a comparison tests for the Schematic tool.